-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link recently_discovered_pods widget to rpt #14493
Conversation
Thanks @kbrock makes perfect sense. @kbrock I wonder if we should refuse to seed these in the database if they have an id (explicit ERROR), or if we should have a spec test over these yaml... these would catch future mistakes. |
The ids are not consistent in the database across installs Updated recently_discovered_pods widget to point to the corresponding report
08abb3c
to
cfded78
Compare
ugh - bad push. trying to get green (think master is failing) @nimrodshn to follow up on your comment. All the other reports you created were both good and consistent. So it took seconds to fix. (I'm trying to say thanks) |
Checked commit kbrock@cfded78 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
@kbrock Does this need to go to euwe? |
This was introduced in 12/6/2016 by #13055 |
Background
Widgets link to reports by report name.
This is because the ids in our database are not consistent across installs.
There is one widget that references a report by id.
Action
I updated the
recently_discovered_pods
widget to point to the report with the same name.why do you think this is the right report?
like '%discovered%'
)links
No BZ associated. I found while scanning through widget meta-data
/cc @nimrodshn FYI