Raise a notification when the embedded ansible server starts #14529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This process can take quite a long time (at least 10 minutes to do the initial configuration and about 4 minutes to start) so it would be good to give the user an idea of when they will be able to start using the ansible based features. https://www.pivotaltracker.com/story/show/142511083
|
Here's a screenshot for the curious.
|
|
I'm up for suggestions as to whether we want to do this every time the thing gets started or only for the first time (when it's configured). I made the notification type generic, so it could fit any long-running role setup, but we could also change it to be more specific to this use case. I'm not sure what the guidelines around new notification types are ... |
|
Checked commit carbonin@4862335 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This process can take quite a long time (at least 10 minutes to do the initial configuration and about 4 minutes to start) so it would be good to give the user an idea of when they will be able to start using the ansible based features.
https://www.pivotaltracker.com/story/show/142511083
/cc @mkanoor