Return correct resource hrefs

[jntullo]

This PR fixes a bug where the hrefs being returned do not match those of the collection they were requested from.

For a service request retrieved via /api/requests/:id, the resource is being returned with:

{
   "href" : "/api/service_requests/:id"
  ...
}

On the collection, GET /api/requests?expand=resources returns inconsistent hrefs, ie:

{
   "resources":[
      {"href": "/api/provision_requests/:id" ...},
      {"href": "/api/service_requests/:id"...},
      {"href": "/api/automation_requests/:id"...},
      {"href": "/api/requests/:id"...}
   ]
}

This change ensures that all hrefs from GET /api/requests?expand=resources will be consistent:

{
   "resources":[
      {"href": "/api/requests/:id" ...},
      {"href": "/api/requests/:id"...},
      {"href": "/api/equests/:id"...},
      {"href": "/api/requests/:id"...}
   ]
}

and that the call to GET /api/requests/:id will also return a matching href:

{
   "href" : "/api/requests/:id"
  ...
}

for any subclass of MiqRequest

Additional tests for service catalogs and tenant quotas were added to ensure that the correct href is being returned when it is a different object than the requested resource

@miq-bot add_label bug, api
@miq-bot assign @abellotti

[abellotti]

collection_config.name_for_klass(rclass) || reftype

[abellotti]

I wonder if above too can't be combined as:

return reftype if collection_class == rclass
collection_config.name_for_subclass(rclass) || reftype

[abellotti]

would this work with the provider_class parameter ?

GET /api/vms?collection_class=ManageIQ::Providers::CloudManager::Vm

[jntullo]

@abellotti it works with the collection_class parameter

[abellotti]

Hi @jntullo can you switch those 2 tests, collection_class == rclass would be more common, so we'd improve the performance here.

[abellotti]

can this be replaced by line 400 below with something like:

  expect_single_resource_query(order_request.merge("href" => a_string_matching(service_requests_url))) 

though I'm not sure if a_string_matching works with that method. maybe just.

  expect_single_resource_query(order_request.merge("href" => /service_requests/) )

Thanks

[miq-bot]

Checked commit jntullo@760c5e2 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 0 offenses detected
Everything looks good. 🍪

[abellotti]

Thanks @jntullo for fixing this !! 😍

[simaishi]

Fine backport details:

$ git log -1
commit 6ebc02003489b791f94235de65c87f0c08a2038e
Author: Alberto Bellotti <[email protected]>
Date:   Thu Apr 6 13:45:17 2017 -0400

    Merge pull request #14549 from jntullo/bug/incorrect_href_specified
    
    Return correct resource hrefs
    (cherry picked from commit fbb84f2cc3463d1808fd4e86a0303bc26d2a9eba)

[simaishi]

@jntullo @abellotti will it be a problem backporting this to Euwe?

[jntullo]

@simaishi there are some conflicts, I will create a separate PR for Euwe

[simaishi]

@jntullo thank you - please remove the conflict label when PR is ready!

[jntullo]

@miq_bot remove_label conflict

PR: #15238

[simaishi]

Backported to Euwe via #15238