Nullify dependents when destroying configuration_script_sources/configuration_scripts #14567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameswnl
force-pushed
the
nullify-dependents
branch
from
a129798
to
1b81b6f
Compare
|
@jameswnl Cannot apply the following label because they are not recognized: providers/ansible_provider |
|
@miq-bot add_labels providers/ansible_tower |
|
@miq-bot add_label fine/yes |
|
@miq-bot add_label euwe/no |
bdunne
requested changes
Apr 3, 2017
| @@ -1,5 +1,5 @@ | |||
| class ConfigurationScriptSource < ApplicationRecord | |||
| has_many :configuration_script_payloads | |||
| has_many :configuration_script_payloads, :dependent => :nullify | |||
There was a problem hiding this comment.
I think this should be :dependent => :destroy since the playbook is an array off of the project in tower.
There was a problem hiding this comment.
Yes, meant to change this to :destroy after chatting with @bzwei , but got distracted by other bugs.
Now done. Thanks!
…onfiguration_scripts ManageIQ#14432
jameswnl
force-pushed
the
nullify-dependents
branch
from
1b81b6f
to
ff08d81
Compare
|
Checked commit jameswnl@ff08d81 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
bdunne
approved these changes
Apr 3, 2017
simaishi
pushed a commit
that referenced
this pull request
Apr 3, 2017
Nullify dependents when destroying configuration_script_sources/configuration_scripts (cherry picked from commit 2875c6c) https://bugzilla.redhat.com/show_bug.cgi?id=1438594
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing https://bugzilla.redhat.com/show_bug.cgi?id=1437108
Once #14432 is in, this similar issue will happen to configuration_scripts and it's children.
@miq-bot add_labels bug, providers/ansible_provider