Notify when an Openstack VM has been relocated #14604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isimluk
suggested changes
Apr 3, 2017
mansam
force-pushed
the
openstack_vm_operation_notifications
branch
from
eabb410
to
46f565c
Compare
isimluk
reviewed
Apr 4, 2017
| connection.live_migrate_server(ems_ref, hostname, block_migration, disk_over_commit) | ||
| rescue => ex | ||
| error_message = parse_error_message_from_fog_response(ex.to_s) | ||
| Notification.create(:type => :vm_cloud_live_migrate_error, :options => {:instance_name => name, :error_message => error_message}) |
There was a problem hiding this comment.
Shouldn't we re-throw the exception?
So, the raw_power_state is not modified? (or any other side-effects)
There was a problem hiding this comment.
Yes, it absolutely should be reraised.
mansam
force-pushed
the
openstack_vm_operation_notifications
branch
from
6410e85
to
011199e
Compare
|
Checked commits mansam/manageiq@46f565c~...011199e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emitting a notification when an Openstack VM relocation operation completes (successfully or otherwise) will allow the UI to further decouple from the underlying API call, rather than having to wait to report on its completion.