Make worker_monitor_drb act like a reader again! #14638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbonin
approved these changes
Apr 4, 2017
There was a problem hiding this comment.
You can probably also remove
manageiq/app/models/miq_worker/runner.rb
Line 358 in 4a0ec8c
Otherwise looks good 👍
https://bugzilla.redhat.com/show_bug.cgi?id=1438935 For testing in e21d1b9, @worker_monitor_drb was changed to use the method. Unfortunately, this method isn't a reader, so it would create a new drb client each time it was called. It doesn't make sense for this method to make a new drb client each time, so we can cache this client on first access so it functions like a attr_reader now. We can then remove some memoization/caching that occurs in heartbeat since the getter method handles that for us.
jrafanie
force-pushed
the
fix_worker_monitor_drb_new_client_each_time
branch
from
147aa6b
to
a9726db
Compare
|
Checked commit jrafanie@a9726db with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/models/miq_worker/runner.rb
|
|
@gtanzillo Making this a blocker since it floods the logs. Additionally, it creates a new DRb client each time we process a queue message, so it needs this PR fix. |
simaishi
pushed a commit
that referenced
this pull request
Apr 5, 2017
…ient_each_time Make worker_monitor_drb act like a reader again! (cherry picked from commit 56ee45a) https://bugzilla.redhat.com/show_bug.cgi?id=1439303
|
Fine backport details: |
simaishi
pushed a commit
that referenced
this pull request
Apr 6, 2017
…ient_each_time Make worker_monitor_drb act like a reader again! (cherry picked from commit 56ee45a) https://bugzilla.redhat.com/show_bug.cgi?id=1439308
|
Euwe backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1438935
For testing in e21d1b9, @worker_monitor_drb was changed to use the
method. Unfortunately, this method isn't a reader, so it would create a
new drb client each time it was called.
It doesn't make sense for this method to make a new drb client each
time, so we can cache this client on first access so it functions like a
attr_reader now. We can then remove some memoization/caching that
occurs in heartbeat since the getter method handles that for us.
Use 147aa6b?w=1 to ignore whitespace.
Note, the parent PR, #14365, was backported to euwe.