Do not run MiqEventDefinitionSet.seed twice on every start-up #14725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not need to run this twice. We have a mechanism to set
dependencies between the seeds.
On my system, running `10.times { EvmDatabase.seed_last }` gives
:sake: | rows | selects | time | %
------ | ---- | ------- | ---- | ---
Before | ? | ? | 55s | 100%
After | -130 | -130 | 51s | 91%
isimluk
force-pushed
the
do-not-run-MiqEventDefinitionSet.seed-twice
branch
from
d6c17f3
to
82a3afd
Compare
|
Checked commit isimluk@82a3afd with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
I am afraid that refresh graph would take more CPU, memory and LOC to do the same job. |
|
Labeling fine/yes as suggested yesterday by @Fryguy on pm. |
simaishi
pushed a commit
that referenced
this pull request
Apr 13, 2017
…et.seed-twice Do not run MiqEventDefinitionSet.seed twice on every start-up (cherry picked from commit c995366)
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not need to run this twice. We have a mechanism to set dependencies between the seeds.
On my system, running
10.times { EvmDatabase.seed_last }gives