all_ems_in_zone is not a scope yet, so we can't chain 'where' #14792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug introduced in: ManageIQ#14675 We'll do our condition checks on arrays for now, until we can properly use scopes. The scopes will require us to change callers to expect scopes, which is why we're fixing this bug for now.
|
Checked commit jrafanie@bf9868c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/models/mixins/per_ems_worker_mixin.rb
|
|
It's ok |
This was referenced Apr 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced in:
#14675
We'll do our condition checks on arrays for now, until we can properly
use scopes. The scopes will require us to change callers to expect
scopes, which is why we're fixing this bug for now.