Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fetch_path to handle the case where :ws_values is nil. #14797

Merged
merged 1 commit into from
Apr 18, 2017
Merged

Use fetch_path to handle the case where :ws_values is nil. #14797

merged 1 commit into from
Apr 18, 2017

Conversation

lfu
Copy link
Member

@lfu lfu commented Apr 18, 2017

When :ws_values is nil, CustomizationTemplate.substitute_erb throws out [NoMethodError]: undefined method `[]' for nil:NilClass.

https://bugzilla.redhat.com/show_bug.cgi?id=1436194

@lfu
Use fetch_path to handle the case where :ws_values is nil.
fbf87f1 
When :ws_values is nil, CustomizationTemplate.substitute_erb throws out [NoMethodError]: undefined method `[]' for nil:NilClass.

https://bugzilla.redhat.com/show_bug.cgi?id=1436194
@miq-bot
Copy link
Member

miq-bot commented Apr 18, 2017

Checked commit lfu@fbf87f1 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. 🏆

@lfu
Copy link
Member Author

lfu commented Apr 18, 2017

@miq-bot assign @gmcculloug
@miq-bot add_label bug, fine/yes, euwe/yes, darga/yes
cc @bdunne

bdunne
bdunne approved these changes Apr 18, 2017
View reviewed changes
Copy link
Member

@bdunne bdunne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@bdunne bdunne merged commit 1a4bcfb into ManageIQ:master Apr 18, 2017
@bdunne bdunne added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 18, 2017
simaishi pushed a commit that referenced this pull request Apr 20, 2017
@bdunne @simaishi
Merge pull request #14797 from lfu/ssh_key_add_template_1436194
d4763ef 
Use fetch_path to handle the case where :ws_values is nil.
(cherry picked from commit 1a4bcfb)

https://bugzilla.redhat.com/show_bug.cgi?id=1443571
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit d4763efa18d3e3a7b89f29afc0c6286f5ae436a6
Author: Brandon Dunne <[email protected]>
Date:   Tue Apr 18 16:40:51 2017 -0400

    Merge pull request #14797 from lfu/ssh_key_add_template_1436194
    
    Use fetch_path to handle the case where :ws_values is nil.
    (cherry picked from commit 1a4bcfb05f9cc37ac76d310bf857a63f7352d0fc)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1443571

simaishi pushed a commit that referenced this pull request May 4, 2017
@bdunne @simaishi
Merge pull request #14797 from lfu/ssh_key_add_template_1436194
ddd3fd0 
Use fetch_path to handle the case where :ws_values is nil.
(cherry picked from commit 1a4bcfb)

https://bugzilla.redhat.com/show_bug.cgi?id=1443572
@simaishi
Copy link
Contributor

simaishi commented May 4, 2017

Euwe backport details:

$ git log -1
commit ddd3fd0096a3a26ab6b10b9b21c0a8c57d5eabc7
Author: Brandon Dunne <[email protected]>
Date:   Tue Apr 18 16:40:51 2017 -0400

    Merge pull request #14797 from lfu/ssh_key_add_template_1436194
    
    Use fetch_path to handle the case where :ws_values is nil.
    (cherry picked from commit 1a4bcfb05f9cc37ac76d310bf857a63f7352d0fc)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1443572

@lfu lfu deleted the ssh_key_add_template_1436194 branch October 16, 2017 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdunne bdunne bdunne approved these changes

Assignees

@gmcculloug gmcculloug

Labels
bug euwe/backported fine/backported lifecycle/provisioning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lfu @miq-bot @simaishi @bdunne @gmcculloug