Do not store whole container env. in the reporting worker forever #14807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isimluk
changed the title
|
This pull request is not mergeable. Please rebase and repush. |
isimluk
force-pushed
the
cb-container-performance-memory
branch
from
229093f
to
0e506da
Compare
In big openshift environments do not use Class variables to store whole environemnt forever. Ugly but it plugs memory leak.
isimluk
force-pushed
the
cb-container-performance-memory
branch
from
0e506da
to
0114f3d
Compare
|
Checked commit isimluk@0114f3d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@gtanzillo improved the patch a little bit and added bz. |
simaishi
pushed a commit
that referenced
this pull request
Apr 20, 2017
Do not store whole container env. in the reporting worker forever (cherry picked from commit 45ac9b6) https://bugzilla.redhat.com/show_bug.cgi?id=1444050
|
Fine backport details: |
simaishi
pushed a commit
that referenced
this pull request
Apr 26, 2017
Do not store whole container env. in the reporting worker forever (cherry picked from commit 45ac9b6) https://bugzilla.redhat.com/show_bug.cgi?id=1444052
|
Euwe backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In big openshift environments do not use Class variables to store whole environment forever. Plugs memory leak.
https://bugzilla.redhat.com/show_bug.cgi?id=1443606