Report attributes for SUI #14829
Merged
Report attributes for SUI #14829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit jntullo@03b5dac with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per this BZ, some fields in the SUI are not populated on the reports screen because they are not available via the API. These fields are the human readable version of the report's condition as well as the "based_on" value.
The
based_onmethod in this PR uses the same call that the classic-ui uses to populate the based_on value.This fix adds these values as virtual columns as there is currently no method support in the API
@miq-bot add_label enhancement, reporting
@miq-bot assign @gtanzillo