Method for Human name of virtual custom attributes #14835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
example: to_human(‘virtual_custom_attribute_some_name’) => ‘Custom Attribute: some_name’ to_human(‘virtual_custom_attribute_some_name:SECTION:docker_labels’) => ‘Docker Labels: some_name’
|
@lpichler Cannot apply the following label because they are not recognized: enhacement |
|
@miq-bot add_label euwe/yes, fine/yes |
|
Checked commits lpichler/manageiq@b64bf9b~...b3c4507 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
This was referenced Apr 21, 2017
|
cc @zeari |
zeari
approved these changes
Apr 23, 2017
simaishi
pushed a commit
that referenced
this pull request
Apr 25, 2017
…attribute Method for Human name of virtual custom attributes (cherry picked from commit 995b737)
|
Fine backport details: |
|
Backported to Euwe via #14971 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pulled out from #14823
Get human name for virtual custom attribute with section
example:
This PR together with UI ManageIQ/manageiq-ui-classic#1099 is using the method for displaying human form of virtual custom attributes in report definition:
At this moment are custom attribute displayed in the format:
'Custom Attribute: some_name'
@miq-bot add_label enhacement, core
@miq-bot assign @gtanzillo
Links
follow up of #14391
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1434077
UI PR: ManageIQ/manageiq-ui-classic#1099