It's _log, not log and we don't need the undefined variable prefix #14846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug introduced in: ManageIQ@18ffca9 Note, this shouldn't be fatal since we're just losing a log message. The next line is exiting the Thread anyway.
|
Checked commit jrafanie@7e82dc8 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
carbonin
approved these changes
Apr 21, 2017
simaishi
pushed a commit
that referenced
this pull request
Apr 24, 2017
It's _log, not log and we don't need the undefined variable prefix (cherry picked from commit 9ea131e)
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced in:
18ffca9
Note, this shouldn't be fatal since we're just losing a log message.
The next line is exiting the Thread anyway.