Allow descendants of Host model to use belongsto filters in RBAC #14852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example: Nowadays we have one descendant of Host and it is: ManageIQ::Providers::Vmware::InfraManager::HostEsx
|
@miq-bot add_label blocker |
|
CI failure is not related to this PR. |
jrafanie
reviewed
Apr 24, 2017
spec/lib/rbac/filterer_spec.rb
Outdated
| group.entitlement.set_managed_filters([['/managed/environment/prod']]) | ||
| group.save! | ||
|
|
||
| @host_1.tag_with(['/managed/environment/prod'].join(' '), :ns => '*') |
There was a problem hiding this comment.
'/managed/environment/prod'].join(' ') should be '/managed/environment/prod'
There was a problem hiding this comment.
I'll open a PR to remove the other unneeded [].join(' ') in the file.
There was a problem hiding this comment.
👍 fixed
I'll open a PR to remove the other unneeded [].join(' ') in the file.
thanks !!!
lpichler
force-pushed
the
allow_descendats_of_host_model_to_use_belongsto_filters
branch
from
4f3beb9
to
89320b3
Compare
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Apr 24, 2017
Seen in ManageIQ#14852 It's already a single string, there's no need to wrap it in an array and join the single element with a space.
|
Checked commits lpichler/manageiq@30fee49~...89320b3 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Merged
simaishi
pushed a commit
that referenced
this pull request
Apr 24, 2017
…l_to_use_belongsto_filters Allow descendants of Host model to use belongsto filters in RBAC (cherry picked from commit 4bcba39) https://bugzilla.redhat.com/show_bug.cgi?id=1445075
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1443929
we have Host model and his descendant is only
ManageIQ::Providers::Vmware::InfraManager::HostEsxmodelbut when input (Host object) to RBAC had its subclass
ManageIQ::Providers::Vmware::InfraManager::HostEsxthen belongs to filters are not used
so in this PR it is allowed aslo for Host's subclasses.
@miq-bot add_label bug, rbac, core
@miq-bot assign @gtanzillo