[SCVMM] Always assume a string for run_powershell_script

[djberg96]

This fixes an issue where our run_powershell_script method was assuming a file argument, but in most cases a string (heredoc) argument was being passed instead.

This PR alters the code so that it's always assumes a string instead of a file.

https://bugzilla.redhat.com/show_bug.cgi?id=1444201

[djberg96]

@miq-bot add_label fine/yes

[djberg96]

@miq-bot add_label euwe/no

[djberg96]

@miq-bot add_label darga/no

[jerryk55]

LGTM, not that anybody asked. :-)

[djberg96]

@jerryk55 Appreciated!

[jteehan]

Verified against 5.8.0.11 and the ERR message is no longer present. This fix is working fine.

[blomquisg]

Does this have to be an instance var? Looks like it's just used on the next line.

[djberg96]

I figured I would do that just in case we needed it elsewhere someday.

[djberg96]

@blomquisg ok, changed it. :)

[bronaghs]

@djberg96 - what caused this to break all of a sudden?

[djberg96]

@bronaghs I think I broke something in the process of cleaning up some things while I was working on the refresh parser revamp.

[miq-bot]

Checked commit https://github.com/djberg96/manageiq/commit/4337c139afbcdf729e6a9f8c1a67c335e1fca658 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 4 offenses detected

spec/models/manageiq/providers/microsoft/infra_manager/powershell_spec.rb

• ❗ - Line 11, Col 7 - Style/SingleLineMethods - Avoid single-line method definitions.
• ❗ - Line 12, Col 7 - Style/EmptyLineBetweenDefs - Use empty lines between method definitions.
• ❗ - Line 12, Col 7 - Style/SingleLineMethods - Avoid single-line method definitions.
• ❗ - Line 7, Col 7 - Style/SingleLineMethods - Avoid single-line method definitions.

[simaishi]

Fine backport details:

$ git log -1
commit 5c356b524ca1da820084446c4f7e356f6f192cf0
Author: Greg Blomquist <[email protected]>
Date:   Tue Apr 25 10:58:01 2017 -0400

    Merge pull request #14859 from djberg96/powershell2
    
    [SCVMM] Always assume a string for run_powershell_script
    (cherry picked from commit a3cafd81b6d1d579343374a32e2c3078e16d7816)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1445936