Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the db application_name after the server row is created #14904

Conversation

jrafanie
Copy link
Member

@jrafanie jrafanie commented Apr 26, 2017

https://bugzilla.redhat.com/show_bug.cgi?id=1445928

Fixes a bug in #13856 when you run rake evm:start on a database without
a server row for the current server: undefined method
database_application_name for nil:NilClass.

Fixes a bug in ManageIQ#13856 when you run rake evm:start on a database without
a server row for the current server: undefined method
database_application_name for nil:NilClass.
@miq-bot
Copy link
Member

miq-bot commented Apr 26, 2017

Checked commit jrafanie@a77023f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gtanzillo gtanzillo added this to the Sprint 60 Ending May 8, 2017 milestone Apr 26, 2017
@gtanzillo gtanzillo merged commit 90197b1 into ManageIQ:master Apr 26, 2017
@jrafanie jrafanie deleted the set_db_application_name_after_server_row_created branch April 26, 2017 19:42
jrafanie pushed a commit to jrafanie/manageiq that referenced this pull request Apr 26, 2017
…me_after_server_row_created

Set the db application_name after the server row is created
jrafanie pushed a commit to jrafanie/manageiq that referenced this pull request Apr 26, 2017
…me_after_server_row_created

Set the db application_name after the server row is created
simaishi pushed a commit that referenced this pull request Jun 2, 2017
…_server_row_created

Set the db application_name after the server row is created
(cherry picked from commit 90197b1)

https://bugzilla.redhat.com/show_bug.cgi?id=1458339
@simaishi
Copy link
Contributor

simaishi commented Jun 2, 2017

Fine backport details:

$ git log -1
commit 451dbfc9822110eba3052342efc58e7c34e36a55
Author: Gregg Tanzillo <[email protected]>
Date:   Wed Apr 26 15:40:41 2017 -0400

    Merge pull request #14904 from jrafanie/set_db_application_name_after_server_row_created
    
    Set the db application_name after the server row is created
    (cherry picked from commit 90197b1485c6fe03649be3bfb51e48fda3aab9b7)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1458339

@simaishi
Copy link
Contributor

Changing to euwe/backported as Euwe version of this PR (#14909) was merged a while ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants