Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move public/external network method into base class #14920

Merged
merged 1 commit into from
May 4, 2017
Merged

Move public/external network method into base class #14920

merged 1 commit into from
May 4, 2017

Conversation

Ladas
Copy link
Contributor

@Ladas Ladas commented Apr 27, 2017

Move public/external network method into base class, since
external network can be attached directly to a Vm, under some
circumstances.

Fixes BZ:
https://bugzilla.redhat.com/show_bug.cgi?id=1431370

@Ladas
Move public/external network method into base class
70edcc4 
Move public/external network method into base class, since
external network can be attached directly to a Vm, under some
circumstances.

Fixes BZ:
https://bugzilla.redhat.com/show_bug.cgi?id=1431370
@miq-bot
Copy link
Member

miq-bot commented Apr 27, 2017

Checked commit Ladas@70edcc4 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@Ladas
Copy link
Contributor Author

Ladas commented Apr 27, 2017

@miq-bot assign @blomquisg
cc @tzumainn

related PR ManageIQ/manageiq-providers-openstack#27

@Ladas
Copy link
Contributor Author

Ladas commented Apr 27, 2017

@tzumainn can you help me test this + make sure it gets backported where it needed? Plus we should have the VCR env enhanced with this combination as well as QE tests should be.

@tzumainn
Copy link
Contributor

@miq-bot add_label fine/no

@tzumainn
Copy link
Contributor

👍 tested, works as advertised!

@tzumainn tzumainn mentioned this pull request Apr 27, 2017
Merged
@Ladas
Copy link
Contributor Author

Ladas commented May 4, 2017

@blomquisg bump

@blomquisg blomquisg merged commit 4c2da55 into ManageIQ:master May 4, 2017
@blomquisg blomquisg added this to the Sprint 60 Ending May 8, 2017 milestone May 4, 2017
@alexander-demicev alexander-demicev mentioned this pull request Feb 7, 2018
Closed
@alexander-demicev
Copy link

alexander-demicev commented Feb 7, 2018 •
edited
Loading

@simaishi Can I ask to backport this into fine? This should fix https://bugzilla.redhat.com/show_bug.cgi?id=1507509 and is related to #16963

@simaishi
Copy link
Contributor

simaishi commented Feb 7, 2018

@alexander-demichev if this change can go to Fine branch as is, please change the label to fine/yes. We're taking blocker PRs only right now for Fine branch, so I'll backport once we start working on the next release.

@alexander-demicev
Copy link

@miq-bot add_label fine/yes

@simaishi simaishi removed the fine/no label Feb 28, 2018
simaishi pushed a commit that referenced this pull request Apr 9, 2018
@blomquisg @simaishi
Merge pull request #14920 from Ladas/move_public_network_methods_to_b…
022eba5 
…ase_class

Move public/external network method into base class
(cherry picked from commit 4c2da55)

https://bugzilla.redhat.com/show_bug.cgi?id=1552233
@simaishi
Copy link
Contributor

simaishi commented Apr 9, 2018

Fine backport details:

$ git log -1
commit 022eba54aa93c79b487ba835919cd153b6894d0c
Author: Greg Blomquist <[email protected]>
Date:   Thu May 4 08:44:26 2017 -0400

    Merge pull request #14920 from Ladas/move_public_network_methods_to_base_class
    
    Move public/external network method into base class
    (cherry picked from commit 4c2da55b1adb5747c3e4ca3b5ef213f1405954a0)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1552233

d-m-u pushed a commit to d-m-u/manageiq that referenced this pull request Jun 6, 2018
@blomquisg @d-m-u
Merge pull request ManageIQ#14920 from Ladas/move_public_network_meth…
18c0013 
…ods_to_base_class

Move public/external network method into base class
(cherry picked from commit 4c2da55)

https://bugzilla.redhat.com/show_bug.cgi?id=1552233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@blomquisg blomquisg

Labels
bug fine/backported providers/network
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Ladas @miq-bot @tzumainn @alexander-demicev @simaishi @blomquisg