Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing units on VMDB Utilization page for disk size #14921

Merged
merged 1 commit into from
May 3, 2017

Conversation

PanSpagetka
Copy link
Contributor

@PanSpagetka PanSpagetka commented Apr 27, 2017

Add missing units on VMDB Utilization page for disk size.

Screenshots

Before:
vmdb_utilization

After:
screenshot from 2017-04-27 14-04-13

Links [Optional]

https://bugzilla.redhat.com/show_bug.cgi?id=1445465

Steps for Testing/QA [Optional]

1.Navigate to Configure-> Diagnostics.
2.On the VMDB Utilization page, click the Utilization tab.
3.Zoom in on the Disk size graph.

@miq-bot
Copy link
Member

miq-bot commented Apr 27, 2017

Checked commit PanSpagetka@ab43435 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@dclarizio
Copy link

@chessbyte Looks nice! Big time 👍

@isimluk isimluk self-requested a review May 3, 2017 09:12
Copy link
Member

@isimluk isimluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@isimluk
Copy link
Member

isimluk commented May 3, 2017

Giving euwe/no, in euwe we show size in MB and the chart name reads Disk Size (MB)

@isimluk isimluk added this to the Sprint 60 Ending May 8, 2017 milestone May 3, 2017
@isimluk isimluk assigned isimluk and unassigned dclarizio May 3, 2017
@isimluk isimluk merged commit 0e06d76 into ManageIQ:master May 3, 2017
simaishi pushed a commit that referenced this pull request Jun 13, 2017
Add missing units on VMDB Utilization page for disk size
(cherry picked from commit 0e06d76)

https://bugzilla.redhat.com/show_bug.cgi?id=1461103
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 31403de8e7654ceb1b6c7584fba5e961b53bbd4b
Author: Šimon Lukašík <[email protected]>
Date:   Wed May 3 12:32:50 2017 +0200

    Merge pull request #14921 from PanSpagetka/missing-unit-on-VMDB-util
    
    Add missing units on VMDB Utilization page for disk size
    (cherry picked from commit 0e06d761b9aa55ea008d7e9944920983e56e08c9)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1461103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants