Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add middleware models to direct RBAC #15011

Merged
merged 3 commits into from
May 10, 2017
Merged

Add middleware models to direct RBAC #15011

merged 3 commits into from
May 10, 2017

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented May 5, 2017

these models can be tagged

          MiddlewareDatasource
          MiddlewareDeployment
          MiddlewareDomain
          MiddlewareMessaging
          MiddlewareServer
          MiddlewareServerGroup

but RBAC search did not count with them.

So this PR is adding these models to direct RBAC to be able to use tags for RBAC filtering.

@karelhala - I guess that I took all related models to the middleware provider

Links

https://bugzilla.redhat.com/show_bug.cgi?id=1442964

MiqBot

@miq-bot add_label rbac, bug
@miq-bot assign @gtanzillo

@miq-bot
Copy link
Member

miq-bot commented May 5, 2017

Checked commits lpichler/manageiq@8abc55e~...ef6a44c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

gtanzillo
gtanzillo approved these changes May 10, 2017
View reviewed changes
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@gtanzillo gtanzillo added this to the Sprint 61 Ending May 22, 2017 milestone May 10, 2017
@gtanzillo gtanzillo merged commit 66684f5 into ManageIQ:master May 10, 2017
@lpichler lpichler deleted the add_middleware_classes_to_direct_rbac branch May 10, 2017 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtanzillo gtanzillo gtanzillo approved these changes

Assignees

@gtanzillo gtanzillo

Labels
bug core/rbac
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lpichler @miq-bot @gtanzillo