Change retire_now to pass zone_name to raise_retirement_event. #15026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinaafitz
force-pushed
the
add_zone_to_retirement
branch
from
772772e
to
cf6357a
Compare
mkanoor
approved these changes
May 8, 2017
tinaafitz
changed the title
tinaafitz
force-pushed
the
add_zone_to_retirement
branch
from
cf6357a
to
4c43c0e
Compare
mkanoor
approved these changes
May 9, 2017
gmcculloug
reviewed
May 9, 2017
| @@ -198,6 +198,10 @@ def error_retiring? | |||
|
|
|||
| private | |||
|
|
|||
| def retire_queue_options | |||
| try(:my_zone) ? {:zone => my_zone} : {} | |||
There was a problem hiding this comment.
@tinaafitz If my_zone returns nil this will pass {:zone => nil}. Will that have the expected results? Or should we only pass the zone_name if we have an actual name? It is unclear to me which is correct.
cc @mkanoor
Separate Automate engine miq_ae_event change required. https://bugzilla.redhat.com/show_bug.cgi?id=1447625
tinaafitz
force-pushed
the
add_zone_to_retirement
branch
from
4c43c0e
to
7239d70
Compare
|
Checked commit tinaafitz@7239d70 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
simaishi
pushed a commit
that referenced
this pull request
May 10, 2017
Change retire_now to pass zone_name to raise_retirement_event. (cherry picked from commit 9e5df30) https://bugzilla.redhat.com/show_bug.cgi?id=1449748
|
Fine backport details: |
simaishi
pushed a commit
that referenced
this pull request
May 10, 2017
Change retire_now to pass zone_name to raise_retirement_event. (cherry picked from commit 9e5df30) https://bugzilla.redhat.com/show_bug.cgi?id=1449753
|
Euwe backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass zone as option to raise_evm_event.
Separate Automate engine miq_ae_event change required.
https://bugzilla.redhat.com/show_bug.cgi?id=1447625
Related PR ManageIQ/manageiq-automation_engine#18