Removed grouping from all Middleware* views #15042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made it consistent with other view yamls where we do not set grouping in other list view yamls, this was causing an extra row for each name entry in the downloadable pdf file to show grouping by name. https://bugzilla.redhat.com/show_bug.cgi?id=1442854
|
Checked commit h-kataria@08506dd with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@chessbyte changes look good to me, consistent with views in other areas. |
simaishi
pushed a commit
that referenced
this pull request
Jun 5, 2017
…are_views Removed grouping from all Middleware* views (cherry picked from commit ba54d13) https://bugzilla.redhat.com/show_bug.cgi?id=1458945
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made it consistent with other view yamls where we do not set grouping in other list view yamls, this was causing an extra row for each name entry in the downloadable pdf file to show grouping by name.
https://bugzilla.redhat.com/show_bug.cgi?id=1442854
before:
after:
@miq-bot add_label bug
@miq-bot add_label fine/yes
@dclarizio please review