Allow Vmdb::Plugins to work through code reloads in development. #15057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. @bdunne did you have reservations with this? |
Fryguy
reviewed
May 10, 2017
lib/vmdb/plugins.rb
Outdated
| @vmdb_plugins.empty? ? register_from_railties : @vmdb_plugins | ||
| end | ||
|
|
||
| def register_from_railties |
There was a problem hiding this comment.
Minor, but I think I'd prefer the method to be called register_vmdb_plugins.
- The name matches the initializer name
- The name mirrors the singular method
register_vmdb_plugin, so you know it's registering all of them - that the plugins are found via railties now is an implementation detail and is subject to possibly change.
|
@hayesr What clears out the |
|
@Fryguy The data is only loaded in an initializer now, so I think when the constant/singleton is reloaded that step is skipped (ie |
hayesr
force-pushed
the
reloadable_plugins
branch
from
3cc8609
to
81b44aa
Compare
|
Checked commits hayesr/manageiq@587eb0f~...81b44aa with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently plugins are registered with
Vmdb::Pluginsat boot. This is fine for production but in development a file change will cause a code reload which clears out plugin information.This change still loads plugin info in an initializer, but reloads it if it has been cleared.