Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SCVMM] Remove -All from Get-SCVMTemplate call #15106

Merged
merged 1 commit into from
May 16, 2017
Merged

[SCVMM] Remove -All from Get-SCVMTemplate call #15106

merged 1 commit into from
May 16, 2017

Conversation

djberg96
Copy link
Contributor

@djberg96 djberg96 commented May 16, 2017 •
edited
Loading

Apparently the -All switch inadvertently included temporary templates, so I'm removing it.

Confirmed with @jteehan that this is correct.

Addresses https://bugzilla.redhat.com/show_bug.cgi?id=1450527

@djberg96 djberg96 changed the title Remove -All from Get-SCVMTemplate call [SCVMM] Remove -All from Get-SCVMTemplate call May 16, 2017
@djberg96
Copy link
Contributor Author

@miq-bot add_label fine/yes

@djberg96
Copy link
Contributor Author

@miq-bot add_label euwe/no

@djberg96
Copy link
Contributor Author

@miq-bot add_label darga/no

@miq-bot
Copy link
Member

miq-bot commented May 16, 2017

Checked commit https://github.com/djberg96/manageiq/commit/3563e865b52c8b78a586b9b922b383cd9aacbc35 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@jteehan
Copy link

jteehan commented May 16, 2017

That will do it. Already tested it.
https://bugzilla.redhat.com/show_bug.cgi?id=1450527

@jteehan
Copy link

jteehan commented May 16, 2017

Merge it so I can get the automation running again.

@blomquisg blomquisg self-requested a review May 16, 2017 17:33
@blomquisg blomquisg self-assigned this May 16, 2017
@blomquisg blomquisg merged commit b8b922b into ManageIQ:master May 16, 2017
@blomquisg blomquisg added this to the Sprint 61 Ending May 22, 2017 milestone May 16, 2017
simaishi pushed a commit that referenced this pull request Jun 5, 2017
@blomquisg @simaishi
Merge pull request #15106 from djberg96/scvmm_templates
e24e89e 
[SCVMM] Remove -All from Get-SCVMTemplate call
(cherry picked from commit b8b922b)

https://bugzilla.redhat.com/show_bug.cgi?id=1458947
@simaishi
Copy link
Contributor

simaishi commented Jun 5, 2017

Fine backport details:

$ git log -1
commit e24e89e3ddd71d3e6aaf1e26b107f4cdee2ab842
Author: Greg Blomquist <[email protected]>
Date:   Tue May 16 13:33:15 2017 -0400

    Merge pull request #15106 from djberg96/scvmm_templates
    
    [SCVMM] Remove -All from Get-SCVMTemplate call
    (cherry picked from commit b8b922b9dd0b7fb37a1cfe7c641b2d2298324022)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1458947

@djberg96 djberg96 deleted the scvmm_templates branch July 18, 2017 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blomquisg blomquisg blomquisg approved these changes

Assignees
No one assigned
Labels
bug fine/backported providers/infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@djberg96 @miq-bot @jteehan @simaishi @blomquisg @Fryguy