Minor inventory collection enhancements #15108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a helper for determining if IC model uses STI
Add checks to build method, build should return nil if we cannot get the unique uuid of the InventoryObject and it should return exiting object if we have it.
|
@miq-bot add_label enhancement |
|
Checked commits Ladas/manageiq@63d81f5~...acaa987 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
chessbyte
reviewed
May 16, 2017
| @@ -378,6 +378,10 @@ def data_collection_finalized? | |||
| data_collection_finalized | |||
| end | |||
|
|
|||
| def supports_sti? | |||
| @supports_sti_cache ||= model_class.column_names.include?("type") | |||
There was a problem hiding this comment.
@Ladas this is the true/false/nil pattern, so you probably need something like the following so you are memoizing and not recalculating when value is false
def supports_sti?
if @supports_sti_cache.nil?
@supports_sti_cache = model_class.column_names.include?("type")
end
@supports_sti_cache
endThere was a problem hiding this comment.
ha, nice catch, you are right of course :-)
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a helper for determining if IC model uses STI. Add checks to build method, build should return nil if we cannot get the unique uuid of the InventoryObject and it should return exiting object if we have it.