Fix sometimes host analysis cannot get the linux packages info #15140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commits NaNi-Z/manageiq@8f0da2a~...3f7af27 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@bdunne 😞Sorry, I don't know how to add a spec test for now, I'm learning. I just test it by my hand. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Linux package’s description has Unicode characters, the host analysis cannot get the packages info.
The result of ssh command(rpm -qa) is ASCII code. When saving the package's info to the xml, it will do some substitution like "\r\n" to "\n". But the regular expression is Unicode(ruby default), so it comes an error.
e.g
The registered trademark character will cause the error.