Adding helper for unique index columns to inventory collection #15141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label enhancement |
|
This pull request is not mergeable. Please rebase and repush. |
Helper for getting unique_index_columns of IC table from a DB, asking for explicit definition if there is more than 1 index and asking for adding unique index if there is none.
Ladas
force-pushed
the
adding_helper_for_unique_index_columns_to_inventory_collection
branch
from
2ec34e6
to
1b68262
Compare
agrare
reviewed
May 19, 2017
| @@ -280,13 +280,16 @@ class InventoryCollection | |||
| # inventory_object[:label] = inventory_object[:name] | |||
| # So by using inventory_object_attributes, we will be guarding the allowed attributes and will have an | |||
| # explicit list of allowed attributes, that can be used also for documentation purposes. | |||
| # @param unique_index_columns [Array] Array of symbols identifying a columns of a DB unique index we will be using. | |||
There was a problem hiding this comment.
identifying a columns
just need identifying columns of a DB ...
agrare
reviewed
May 19, 2017
| def unique_index_columns | ||
| return @unique_index_columns if @unique_index_columns | ||
|
|
||
| unique_indexes = model_class.connection.indexes(model_class.table_name).select { |x| x.unique } |
|
Two small things the rest looks good |
Fix rubocop and grammar issues
|
Checked commits Ladas/manageiq@1b68262~...b0dbd9e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
Helper for getting unique_index_columns of IC table from a DB,
asking for explicit definition if there is more than 1
index and asking for adding unique index if there is none.