Requests should allow access to users with admin role #15151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we check to see if the user is the "admin" user - we need to check to see if the user has administrator priveleges regardless of who they are. Incidentally removes a couple of uses of `any_instance_of` 🎉 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1421878
|
Checked commit imtayadeway@fe0485b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
👍 Thanks @imtayadeway for fixing this. 🎵 |
imtayadeway
added a commit
to imtayadeway/manageiq
that referenced
this pull request
May 19, 2017
This should have been done as part of ManageIQ#15151, which fixed the collection routes. This completes that work by fixing the member routes. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1421878
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we check to see if the user is the "admin" user - we need to
check to see if the user has administrator priveleges regardless of
who they are.
Incidentally removes a couple of uses of
any_instance_of🎉Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1421878
Side note: I'm not sure why they other request types do not allow admin access to all requests, it seems that we should fix that as a follow up to this once merged.
@miq-bot add-label api, bug
@miq-bot assign @abellotti
Thanks @jvlcek for your help debugging this!