Generalize targeted inventory collection saving #15198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generalize targeted saving using the InventoryCollection
Base IC configurations for a CloudManager targeted refresh
Base IC configurations for a CloudManager targeted refresh
Fix rubocop issue with map(&:foreign_key)
|
@miq-bot add_label enhancement |
Autofix rubocop issues
1 task
Fryguy
reviewed
May 23, 2017
| @@ -92,14 +93,22 @@ def hardwares(extra_attributes = {}) | |||
| relation | |||
| end | |||
|
|
|||
| attributes[:targeted_arel] = lambda do |inventory_collection| | |||
| manager_uuids = inventory_collection.parent_inventory_collections.collect(&:manager_uuids).map(&:to_a).flatten | |||
There was a problem hiding this comment.
Prefer .flat_map over .collect.map.flatten
manager_uuids = inventory_collection.parent_inventory_collections.flat_map { |c| c.manager_uuids.to_a }Check for targeted? when scanning targeted dependencies
Use flat_map instead of collect&map&flattten
|
Checked commits Ladas/manageiq@b4bb3fb~...0d0f45d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/models/manager_refresh/inventory_collection.rb
app/models/manager_refresh/inventory_collection_default/cloud_manager.rb
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalize targeted inventory collection saving