Do not calculate useless group metrics #15260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://bugzilla.redhat.com/show_bug.cgi?id=1455690 https://bugzilla.redhat.com/show_bug.cgi?id=1454456 - cpu is useless as it counts usagemhz and vm_numvcpus together - cpu_cores is useless as it only reports cpu_cores - memory is useless as counts used and available together - net_io is useless as it only reports net_ui_rate_avg - disk_io is useless as it only reports disk_usage_rate_avg - storage is useless as it counts used and allocated together - fixed is useless as it counts all the fixed metrics together (that equals to 4 for each day, not useful)
It used to return array with single item, now it just returns that single item. Less object creation -> less fat in the code -> performance goes up.
isimluk
force-pushed
the
do-not-report-useles-group-metric
branch
from
51724d5
to
4b45950
Compare
isimluk
added a commit
to isimluk/manageiq
that referenced
this pull request
May 31, 2017
|
Checked commits isimluk/manageiq@afb10c1~...4b45950 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@isimluk @gtanzillo this can be |
|
Definitely fine/yes. However, I would prefer euwe/no (needs manual backport), unless there is a real need to have it. The other pr can be euwe/yes, effectively fixing that bz. @miq-bot add_label fine/yes, euwe/no |
|
Backported to Euwe via #15337 |
simaishi
pushed a commit
that referenced
this pull request
Jun 12, 2017
Do not calculate useless group metrics (cherry picked from commit d2f04e9) https://bugzilla.redhat.com/show_bug.cgi?id=1459562
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1455690
https://bugzilla.redhat.com/show_bug.cgi?id=1454456
Note this only fixes part of the upper mentioned bzs.