Ensure report columns serialized as hashes have symbolized keys before importing #15273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e importing This fixes a bug where a report imported via the Rest API, as json, fails to generate because the keys in columns serialized as hashes are received as strings. https://bugzilla.redhat.com/show_bug.cgi?id=1456742
|
Checked commit gtanzillo@ef760a7 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/models/miq_report/import_export.rb
spec/models/miq_report/import_export_spec.rb
|
simaishi
pushed a commit
that referenced
this pull request
Jun 5, 2017
Ensure report columns serialized as hashes have symbolized keys before importing (cherry picked from commit 832975b) https://bugzilla.redhat.com/show_bug.cgi?id=1458810
|
Euwe backport details: |
simaishi
pushed a commit
that referenced
this pull request
Jun 9, 2017
Ensure report columns serialized as hashes have symbolized keys before importing (cherry picked from commit 832975b) https://bugzilla.redhat.com/show_bug.cgi?id=1460396
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where a report imported via the Rest API, as json, fails to generate because the keys
in columns serialized as hashes are received as strings.
https://bugzilla.redhat.com/show_bug.cgi?id=1456742