Return an empty relation instead of an array from db_relation() #15325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
db_relation() returns an empty array if it couldn't determine another relation to use. This empty array doesn't work with chained activerecord methods like find_each, and breaks functions like populate_db_data_index!
|
Checked commit mansam@03f6941 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
durandom
approved these changes
Jun 7, 2017
|
nice catch, looks great 👍 |
|
@mansam btw. I've been trying to quickly skip processing of the IC if it would not do anything, by checking inventory_collection.noop? . I am using that in the AWS Targeted Refresh |
|
@Ladas Cool, I'll have to check out the new stuff you've been doing in the Amazon repo. |
|
@mansam the targeted refresh is more integrated to the InventoryCollection now, so soon we should be able to move to the class level definition like we have in Ansible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
db_relation()returns an empty array if it couldn't determine another relation to use. This empty array doesn't work with chained activerecord methods like find_each, and breaks functions that assume they've been given an activerecord relation likepopulate_db_data_index!This PR fixes the problem by using the inventory collection's model class to return a null relation which behaves correctly with chained activerecord methods.