Add orchestration stack my_zone. #15334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot assign @gmcculloug |
tinaafitz
force-pushed
the
orchestration_stack_add_zone
branch
from
a8b382e
to
c9fc27d
Compare
bzwei
reviewed
Jun 8, 2017
app/models/orchestration_stack.rb
Outdated
| @@ -97,6 +97,10 @@ def raw_update_stack(_template, _options = {}) | |||
| raise NotImplementedError, _("raw_update_stack must be implemented in a subclass") | |||
| end | |||
|
|
|||
| def my_zone | |||
There was a problem hiding this comment.
looks like you need to indent the method
|
LGTM |
tinaafitz
force-pushed
the
orchestration_stack_add_zone
branch
from
c9fc27d
to
d8ef167
Compare
|
Checked commit tinaafitz@d8ef167 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
simaishi
pushed a commit
that referenced
this pull request
Jun 13, 2017
Add orchestration stack my_zone. (cherry picked from commit 8e6d2fb) https://bugzilla.redhat.com/show_bug.cgi?id=1461143
|
Fine backport details: |
|
@miq-bot add_label services |
|
@tinaafitz unrecognized command 'services', ignoring... Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone |
|
@tinaafitz @gmcculloug can this be |
simaishi
pushed a commit
that referenced
this pull request
Jun 30, 2017
Add orchestration stack my_zone. (cherry picked from commit 8e6d2fb) https://bugzilla.redhat.com/show_bug.cgi?id=1465415
|
Euwe backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Orchestration stacks can be retired individually and/or from Services. Retirement puts the retirement request event on the queue and supplies the zone if available. Service retirement for Orchestration stacks has a zone, but the individual Orchestration stack doesn't not.
https://bugzilla.redhat.com/show_bug.cgi?id=1458011