Add AuthKeyPair to RBAC #15359
Merged
Add AuthKeyPair to RBAC #15359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this model is inherited from AuthPrivateKey and then from Authentication. (In CLASSES_THAT_PARTICIPATE_IN_RBAC is list of base classes)
lpichler
force-pushed
the
add_auth_key_pair_rbac
branch
from
1cc351f
to
184297d
Compare
|
Checked commits lpichler/manageiq@deb653a~...184297d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
The whole (Note that this comment may or may not be pertinent to the PR at hand. Just thought I would poke my nose in here) |
|
@djberg96 you are right it is weird, I'll think about it. Maybe there is 'technical reason ' why to model should participate to rbac (that it is using acts_as_miq_taggable) thank you for your comment 👍 |
|
Backported to Fine via #16865 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AuthKeyPairis inherited fromAuthPrivateKeyand then fromAuthentication. (InCLASSES_THAT_PARTICIPATE_IN_RBACis list of base classes)In UI:
Compute -> Cloud -> Key Pairs
@miq-bot add_label bug, rbac
@miq-bot assign @gtanzillo
Links
https://bugzilla.redhat.com/show_bug.cgi?id=1441637