Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch saving strategy should populate the right timestamps #15394

Conversation

Ladas
Copy link
Contributor

@Ladas Ladas commented Jun 19, 2017

Batch saving strategy should populate the right timestamps

@Ladas
Copy link
Contributor Author

Ladas commented Jun 19, 2017

@miq-bot assign @agrare

@Ladas
Copy link
Contributor Author

Ladas commented Jun 19, 2017

@miq-bot add_label enhancement

Batch saving strategy should populate the right timestamps
Supports helpers for timestamp attributes
Supports helper for remote_data_timetamp
@Ladas Ladas force-pushed the batch_saving_strategy_should_populate_the_right_timestamps branch from 4b43988 to 24c5d07 Compare June 20, 2017 13:02
Use supports_remote_data_timestamp? in sql helper
Extract assignment of a common attributes to a base class
Use Time.zone.now instead of localtime
@Ladas Ladas force-pushed the batch_saving_strategy_should_populate_the_right_timestamps branch from 24c5d07 to 193dd12 Compare June 20, 2017 13:07
@miq-bot
Copy link
Member

miq-bot commented Jun 20, 2017

Checked commits Ladas/manageiq@8afc38b~...193dd12 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
5 files checked, 0 offenses detected
Everything looks fine. 🏆

Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agrare agrare added this to the Sprint 63 Ending Jun 19, 2017 milestone Jun 20, 2017
@agrare agrare merged commit 193dd12 into ManageIQ:master Jun 20, 2017
agrare added a commit that referenced this pull request Jun 20, 2017
…ulate_the_right_timestamps

Batch saving strategy should populate the right timestamps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants