Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make db restore more reliable #16942

Merged
merged 4 commits into from
Feb 28, 2018
Merged

Make db restore more reliable #16942

merged 4 commits into from
Feb 28, 2018

Commits on Feb 12, 2018

  1. Check for restore error cases in EvmDatabaseOps 

    This allows us to do more of the processing using existing code
rather than the current implementation which does the checks in
different places/repos and does a lot of shelling out to psql
rather than using a real database connection.

This also makes the error cases more explicit which fixes an issue
where a user could not restore a pg_dump backup when pglogical was
running.

https://bugzilla.redhat.com/show_bug.cgi?id=1540686
    @carbonin
    carbonin committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    898b63d View commit details
    Browse the repository at this point in the history

  2. Add :environment as a prerequisate rake task for restore 

    We need the rails environment to access the VmdbDatabaseConnection
model
    @carbonin
    carbonin committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    4d7af02 View commit details
    Browse the repository at this point in the history

  3. Do the restore without any active connections to the database 

    To do this, we need to disconnect the connection we created when
requiring the :environment rake task to run this method.
    @carbonin
    carbonin committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    e574ad3 View commit details
    Browse the repository at this point in the history

  4. Fix specs after adding check for file type

    @carbonin
    carbonin committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    1876da3 View commit details
    Browse the repository at this point in the history