Changed Feature Name from native to management_console

[DavidResende0]

Follow up to: ManageIQ/manageiq-ui-classic#8758

Changes the feature name for the IBM providers from native_console to management_console since native_console is already used by the RHV provider. Also fixes a bug in the ui that was being caused by this overlap of feature names.

Other PRs:
ui -> ManageIQ/manageiq-ui-classic#8762
Lenovo -> ManageIQ/manageiq-providers-lenovo#389
vmware -> ManageIQ/manageiq-providers-vmware#874
ibm_power_hmc -> ManageIQ/manageiq-providers-ibm_power_hmc#136
ibm_terraform -> ManageIQ/manageiq-providers-ibm_terraform#94
ibm_cloud -> ManageIQ/manageiq-providers-ibm_cloud#451
ibm_power_vc -> ManageIQ/manageiq-providers-ibm_power_vc#90

[DavidResende0]

@agrare can you make sure I'm not missing anything or changed something that's not necessary to change.

[agrare]

We need supports_not :management_console in ExtManagementSystem
We also need to change the supports feature for the supports feature from :native_console to :management_console in the providers which implement console_url for ExtManagementSystems.

[agrare]

@DavidResende0 we still need to update the other providers which implement this at the EMS level per #22474 (review)

[DavidResende0]

@DavidResende0 we still need to update the other providers which implement this at the EMS level per #22474 (review)

Are there other providers besides ManageIQ/manageiq-providers-ibm_power_hmc#136 and ManageIQ/manageiq-providers-ibm_cloud#451 that I'm missing?

Also I'm I missing something in these prs?

[agrare]

Are there other providers besides ManageIQ/manageiq-providers-ibm_power_hmc#136 and ManageIQ/manageiq-providers-ibm_cloud#451 that I'm missing?

Yes, https://github.com/search?q=org%3AManageIQ+%22supports+%3Anative_console%22&type=code

[kbrock]

do we still want the vm_native_console entries?

ugh. this probably requires a migration and everything.

^ ignore. this looks great

[agrare]

Yes because vm_native_console is still a valid feature (ovirt/rhv vm console), it was being overloaded by something else (web browser details page)

[miq-bot]

Checked commit DavidResende0@5c665f5 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 🍰

[agrare]

@DavidResende0 what is the status of this? Were we waiting on testing or other providers?

[DavidResende0]

@DavidResende0 what is the status of this? Were we waiting on testing or other providers?

I think these changes cover all the needed providers and everything seems to work on the one's I've tested but I haven't been able to test every provider.

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).