validate format for SettingsChange#key #22624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrock
force-pushed
the
settings_change_key_format
branch
from
d64c4a0
to
7156256
Compare
|
update:
|
Fryguy
reviewed
Jul 26, 2023
| @@ -1,6 +1,7 @@ | |||
| class SettingsChange < ApplicationRecord | |||
| serialize :value | |||
|
|
|||
| validates :key, :format => %r{\A/[^/]+(/[^/]+)*\z} | |||
There was a problem hiding this comment.
Looks good - can you add some specs?
kbrock
force-pushed
the
settings_change_key_format
branch
from
7156256
to
af56a21
Compare
|
Checked commit kbrock@af56a21 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
|
update:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably for developers only, but this puts validation on the value that goes into the key