Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade fast_gettext #23205

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Upgrade fast_gettext #23205

merged 1 commit into from
Sep 25, 2024

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Sep 24, 2024

This is for ruby 3.2

@@ -44,6 +44,8 @@ jobs:
with:
ruby-version: "${{ matrix.ruby-version }}"
bundler-cache: true
# fix for ovirt-engine-sdk (>4.6.0 should make this not necessary)
gem-install-options: '--with-cflags="-Wno-error=incompatible-function-pointer-types -Wno-error=implicit-function-declaration"'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we determined this wasn't needed?

@miq-bot
Copy link
Member

miq-bot commented Sep 25, 2024

Checked commit kbrock@2b2f5cf with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@kbrock
Copy link
Member Author

kbrock commented Sep 25, 2024

update:

  • removed ci.yml change
  • upgraded gettext to latest version. (reviewed documentation and the changes are minor. They dropped ruby 2.x, hence the major upgrade version

Copy link
Member

@Fryguy Fryguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @jrafanie can you verify that your locale stuff still works with this? I want to say we have tests around the locale stuff, but I'm not 100% sure.

@jrafanie
Copy link
Member

LGTM - @jrafanie can you verify that your locale stuff still works with this? I want to say we have tests around the locale stuff, but I'm not 100% sure.

We have basic po validation on syntax errors and similar. We also have the locale all github action but that can only run against the branches on ManageIQ.

I think you can run locale:all locally. I vaguelly recall you need to have the db for i18n:

i18n:
  <<: *base
  database: vmdb_i18n

Then you should be able to run bundle exec rake locale:update_all. I'll pull down this branch and try it.

@jrafanie
Copy link
Member

Then you should be able to run bundle exec rake locale:update_all. I'll pull down this branch and try it.

It works for me. Considering the changes are minor and mostly due to dropping some old rubies, I think it's safe to update this.

@jrafanie jrafanie merged commit 9637774 into ManageIQ:master Sep 25, 2024
8 checks passed
@kbrock kbrock deleted the fasttext branch September 26, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants