-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade fast_gettext #23205
Upgrade fast_gettext #23205
Conversation
.github/workflows/ci.yaml
Outdated
@@ -44,6 +44,8 @@ jobs: | |||
with: | |||
ruby-version: "${{ matrix.ruby-version }}" | |||
bundler-cache: true | |||
# fix for ovirt-engine-sdk (>4.6.0 should make this not necessary) | |||
gem-install-options: '--with-cflags="-Wno-error=incompatible-function-pointer-types -Wno-error=implicit-function-declaration"' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we determined this wasn't needed?
Checked commit kbrock@2b2f5cf with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
update:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - @jrafanie can you verify that your locale stuff still works with this? I want to say we have tests around the locale stuff, but I'm not 100% sure.
We have basic po validation on syntax errors and similar. We also have the locale all github action but that can only run against the branches on ManageIQ. I think you can run locale:all locally. I vaguelly recall you need to have the db for i18n:
Then you should be able to run |
It works for me. Considering the changes are minor and mostly due to dropping some old rubies, I think it's safe to update this. |
This is for ruby 3.2