Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock URI to 0.13.x #23260

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Lock URI to 0.13.x #23260

merged 1 commit into from
Nov 7, 2024

Conversation

jrafanie
Copy link
Member

@jrafanie jrafanie commented Nov 7, 2024

In 1.0.0, URI::PATTERN constant was removed without a depecation warning: ruby/uri@v0.13.1...v1.0.0#diff-936b286152b1184cde04f027289d65e633d0f3ee52fdc42cf4eb072c24312e15R48-R54

For now, let's stick with 0.13.1 until we can know the proper solution.

Related: https://www.github.com/ruby/uri/issues/125

In 1.0.0, URI::PATTERN constant was removed without a depecation warning:
ruby/uri@v0.13.1...v1.0.0#diff-936b286152b1184cde04f027289d65e633d0f3ee52fdc42cf4eb072c24312e15R48-R54

For now, let's stick with 0.13.1 until we can know the proper solution.

Related: https://www.github.com/ruby/uri/issues/125
@jrafanie jrafanie changed the title Lock URI to 0.13.1 Lock URI to 0.13.x Nov 7, 2024
@bdunne bdunne merged commit 50ff2d0 into ManageIQ:master Nov 7, 2024
12 checks passed
@bdunne bdunne self-assigned this Nov 7, 2024
@jrafanie jrafanie deleted the lock-uri-to-0-13 branch November 7, 2024 22:47
jrafanie added a commit to jrafanie/manageiq-automation_engine that referenced this pull request Nov 8, 2024
Correct error message validation to be less brittle to underlying changes in URI's message format.

Related to:
https://www.github.com/ruby/uri/issues/125
ManageIQ/manageiq#23260
jrafanie added a commit to jrafanie/vmware_web_service that referenced this pull request Nov 8, 2024
jrafanie added a commit to jrafanie/manageiq that referenced this pull request Nov 8, 2024
jrafanie added a commit to jrafanie/vmware_web_service that referenced this pull request Nov 8, 2024
jrafanie added a commit to jrafanie/manageiq that referenced this pull request Nov 8, 2024
jrafanie added a commit to jrafanie/manageiq that referenced this pull request Nov 8, 2024
jrafanie added a commit to jrafanie/vmware_web_service that referenced this pull request Nov 8, 2024
jrafanie added a commit to jrafanie/manageiq-automation_engine that referenced this pull request Nov 8, 2024
Correct error message validation to be less brittle to underlying changes in URI's message format.

Related to:
https://www.github.com/ruby/uri/issues/125
ManageIQ/manageiq#23260
jrafanie added a commit to jrafanie/manageiq-ui-classic that referenced this pull request Nov 8, 2024
jrafanie added a commit to jrafanie/manageiq-gems-pending that referenced this pull request Nov 8, 2024
jrafanie added a commit to jrafanie/manageiq-providers-vmware that referenced this pull request Nov 8, 2024
jrafanie added a commit to jrafanie/manageiq-providers-ovirt that referenced this pull request Nov 8, 2024
jrafanie added a commit to jrafanie/manageiq-automation_engine that referenced this pull request Nov 8, 2024
Correct error message validation to be less brittle to underlying changes in URI's message format.

Related to:
https://www.github.com/ruby/uri/issues/125
ManageIQ/manageiq#23260
jrafanie added a commit to jrafanie/vmware_web_service that referenced this pull request Nov 8, 2024
@Fryguy
Copy link
Member

Fryguy commented Nov 14, 2024

Backported to radjabov in commit 3ea93a4.

commit 3ea93a472e241c8966975502c5df83368f1367e8
Author: Brandon Dunne <[email protected]>
Date:   Thu Nov 7 17:46:13 2024 -0500

    Merge pull request #23260 from jrafanie/lock-uri-to-0-13
    
    Lock URI to 0.13.x
    
    (cherry picked from commit 50ff2d058e1f6db3fc6305724c405bd9c6c2ce85)

Fryguy pushed a commit that referenced this pull request Nov 14, 2024
Lock URI to 0.13.x

(cherry picked from commit 50ff2d0)
Fryguy added a commit to Fryguy/manageiq that referenced this pull request Nov 14, 2024
Fryguy added a commit to Fryguy/manageiq that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants