-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock URI to 0.13.x #23260
Merged
Merged
Lock URI to 0.13.x #23260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 1.0.0, URI::PATTERN constant was removed without a depecation warning: ruby/uri@v0.13.1...v1.0.0#diff-936b286152b1184cde04f027289d65e633d0f3ee52fdc42cf4eb072c24312e15R48-R54 For now, let's stick with 0.13.1 until we can know the proper solution. Related: https://www.github.com/ruby/uri/issues/125
jrafanie
force-pushed
the
lock-uri-to-0-13
branch
from
November 7, 2024 21:56
f37fe7a
to
9ab659f
Compare
jrafanie
added a commit
to jrafanie/manageiq-automation_engine
that referenced
this pull request
Nov 8, 2024
Correct error message validation to be less brittle to underlying changes in URI's message format. Related to: https://www.github.com/ruby/uri/issues/125 ManageIQ/manageiq#23260
2 tasks
jrafanie
added a commit
to jrafanie/vmware_web_service
that referenced
this pull request
Nov 8, 2024
2 tasks
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Nov 8, 2024
9 tasks
jrafanie
added a commit
to jrafanie/vmware_web_service
that referenced
this pull request
Nov 8, 2024
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Nov 8, 2024
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Nov 8, 2024
jrafanie
added a commit
to jrafanie/vmware_web_service
that referenced
this pull request
Nov 8, 2024
jrafanie
added a commit
to jrafanie/manageiq-automation_engine
that referenced
this pull request
Nov 8, 2024
Correct error message validation to be less brittle to underlying changes in URI's message format. Related to: https://www.github.com/ruby/uri/issues/125 ManageIQ/manageiq#23260
jrafanie
added a commit
to jrafanie/manageiq-ui-classic
that referenced
this pull request
Nov 8, 2024
2 tasks
jrafanie
added a commit
to jrafanie/manageiq-gems-pending
that referenced
this pull request
Nov 8, 2024
2 tasks
jrafanie
added a commit
to jrafanie/manageiq-providers-vmware
that referenced
this pull request
Nov 8, 2024
2 tasks
jrafanie
added a commit
to jrafanie/manageiq-providers-ovirt
that referenced
this pull request
Nov 8, 2024
2 tasks
jrafanie
added a commit
to jrafanie/manageiq-automation_engine
that referenced
this pull request
Nov 8, 2024
Correct error message validation to be less brittle to underlying changes in URI's message format. Related to: https://www.github.com/ruby/uri/issues/125 ManageIQ/manageiq#23260
jrafanie
added a commit
to jrafanie/vmware_web_service
that referenced
this pull request
Nov 8, 2024
Backported to
|
Fryguy
pushed a commit
that referenced
this pull request
Nov 14, 2024
Lock URI to 0.13.x (cherry picked from commit 50ff2d0)
Fryguy
added a commit
to Fryguy/manageiq
that referenced
this pull request
Nov 14, 2024
Fryguy
added a commit
to Fryguy/manageiq
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 1.0.0, URI::PATTERN constant was removed without a depecation warning: ruby/uri@v0.13.1...v1.0.0#diff-936b286152b1184cde04f027289d65e633d0f3ee52fdc42cf4eb072c24312e15R48-R54
For now, let's stick with 0.13.1 until we can know the proper solution.
Related: https://www.github.com/ruby/uri/issues/125