Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to pass a transformation block to element_counts #21

Merged
merged 1 commit into from
Oct 15, 2015

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Oct 14, 2015

@bdunne Please review. I found I needed this for the memory_analyzer. Makes counting objects by arbitrary properties a lot easier.

@bdunne
Copy link
Member

bdunne commented Oct 14, 2015

👍 LGTM, merge when green

@miq-bot
Copy link
Member

miq-bot commented Oct 14, 2015

Checked commit Fryguy@2f3667d with ruby 1.9.3, rubocop 0.34.2, and haml-lint 0.13.0
2 files checked, 5 offenses detected

spec/core_ext/array/element_counts_spec.rb

bdunne added a commit that referenced this pull request Oct 15, 2015
Add ability to pass a transformation block to element_counts
@bdunne bdunne merged commit 1275ada into ManageIQ:master Oct 15, 2015
Fryguy added a commit that referenced this pull request Dec 2, 2015
- Breaking changes
 - Remove Object#namespace [#20]

- Other changes
  - Add ability to pass a transformation block to element_counts [#21]
  - Array#include_any? and friends now accept a single argument Array.
    [#18]
  - Upgraded to RSpec 3 [#16]
  - Added CHANGELOG.md!
@Fryguy Fryguy deleted the block_for_element_counts branch December 2, 2015 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants