Extract Numeric#apply_min_max to #clamp #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Fryguy Please review |
Fryguy
reviewed
Sep 20, 2016
| module MoreCoreExtensions | ||
| module NumericClamp | ||
| # | ||
| # Returns the square of a Numeric. |
There was a problem hiding this comment.
Oops, that's what copy / paste gets you ;) I corrected it.
bdunne
force-pushed
the
numeric_clamp
branch
from
c051ccd
to
ecbe1b2
Compare
|
@bdunne Can you please also update the README? |
Fryguy
approved these changes
Dec 16, 2016
bdunne
force-pushed
the
numeric_clamp
branch
from
ecbe1b2
to
74bedbf
Compare
|
<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush. |
Code extracted from extensions in ManageIQ/manageiq https://github.com/ManageIQ/manageiq/blob/e538e47a4e53190daba4f45283c58303d2afedd6/gems/pending/util/extensions/miq-numeric.rb
bdunne
force-pushed
the
numeric_clamp
branch
from
74bedbf
to
109358d
Compare
|
Checked commit bdunne@109358d with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code extracted from extensions in ManageIQ/manageiq
https://github.com/ManageIQ/manageiq/blob/e538e47a4e53190daba4f45283c58303d2afedd6/gems/pending/util/extensions/miq-numeric.rb