Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump more core extensions #80

Merged
merged 1 commit into from
Jul 14, 2020
Merged

bump more core extensions #80

merged 1 commit into from
Jul 14, 2020

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Jun 29, 2020

more core ext's on 4.1.0

update for update sake

https://github.com/ManageIQ/more_core_extensions/compare/179bf40..e5b4501

  • Added Ruby 2.7 support [#79]
  • Added Process#pause, Process#resume, and Process#alive? [#73]

array added * #compact_map - Collect non-nil results from the block
array added #tabular_sort - Sorts an Array of Hashes by specific columns

hierarchy added #descendant_get - Returns the descendant with a given name

the two breaking changes:

  • BREAKING: Moved Object#descendant_get to Class#descendant_get [#75]
  • BREAKING: Removed deprecated Enumerable#stable_sort_by [#76]

a minor header output change was made that hasn't been released yet to make tableize more markdown compliant

see ManageIQ/linux_admin#221

@djberg96
Copy link
Contributor

djberg96 commented Jul 7, 2020

Looks like manageiq-gems-pending will need a corresponding update as well.

d-m-u added a commit to d-m-u/manageiq-gems-pending that referenced this pull request Jul 7, 2020
required by the rest client update in the vmware web service:
ManageIQ/vmware_web_service#80
d-m-u added a commit to d-m-u/manageiq-gems-pending that referenced this pull request Jul 9, 2020
required by the rest client update in the vmware web service:
ManageIQ/vmware_web_service#80
d-m-u added a commit to d-m-u/manageiq-gems-pending that referenced this pull request Jul 10, 2020
required by the rest client update in the vmware web service:
ManageIQ/vmware_web_service#80
@bdunne
Copy link
Member

bdunne commented Jul 13, 2020

Ugh... circular dependency issue. Maybe we can loosen the requirement to spec.add_dependency "more_core_extensions", ">= 3.2", "< 5" since we know that 4.0 doesn't break the things this depends on?

update for update sake

https://github.com/ManageIQ/more_core_extensions/compare/179bf40..e5b4501
 - Added Ruby 2.7 support [[ManageIQ#79](ManageIQ/more_core_extensions#79)]
 - Added Process#pause, Process#resume, and Process#alive? [[ManageIQ#73](ManageIQ/more_core_extensions#73)]

array added * `#compact_map` - Collect non-nil results from the block
array added `#tabular_sort` - Sorts an Array of Hashes by specific columns

hierarchy added `#descendant_get` - Returns the descendant with a given name

the two breaking changes:
- **BREAKING**: Moved Object#descendant_get to Class#descendant_get [[ManageIQ#75](ManageIQ/more_core_extensions#75)]
- **BREAKING**: Removed deprecated Enumerable#stable_sort_by [[ManageIQ#76](ManageIQ/more_core_extensions#76)]

a minor header output change was made that hasn't been released yet to make tableize more markdown compliant

see ManageIQ/linux_admin#221
@miq-bot
Copy link
Member

miq-bot commented Jul 14, 2020

Checked commit d-m-u@54b0061 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. ⭐

Copy link
Member

@bdunne bdunne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM Any reason it's still WIP?

@d-m-u d-m-u changed the title [wip] bump more core extensions bump more core extensions Jul 14, 2020
@d-m-u
Copy link
Contributor Author

d-m-u commented Jul 14, 2020

thanks @bdunne

@miq-bot miq-bot removed the wip label Jul 14, 2020
@bdunne
Copy link
Member

bdunne commented Jul 14, 2020

@agrare Can you review/merge and release a patch version?

@agrare agrare self-assigned this Jul 14, 2020
@agrare agrare merged commit 4b783d8 into ManageIQ:master Jul 14, 2020
@d-m-u d-m-u deleted the bump_mce branch July 14, 2020 13:24
@agrare
Copy link
Member

agrare commented Jul 14, 2020

Released v1.0.6 with this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants