Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing expected response for testkube #370

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

sekka1
Copy link
Collaborator

@sekka1 sekka1 commented Aug 18, 2022

The output for the newest version of the prometheus included in the kube-prometheus-stack for the health check has changed (argg!!!). Updating the text response to be more generic. This change is backwards compatible with older prometheus versions as well.

kubectl -n istio-system exec -it istio-ingressgateway-6d7b845966-cn44n -- bash
istio-proxy@istio-ingressgateway-6d7b845966-cn44n:/$ curl
curl: try 'curl --help' or 'curl --manual' for more information
istio-proxy@istio-ingressgateway-6d7b845966-cn44n:/$ curl -v http://prometheus-operated.monitoring.svc:9090/-/ready
*   Trying 10.117.195.25:9090...
* TCP_NODELAY set
* Connected to prometheus-operated.monitoring.svc (10.117.195.25) port 9090 (#0)
> GET /-/ready HTTP/1.1
> Host: prometheus-operated.monitoring.svc:9090
> User-Agent: curl/7.68.0
> Accept: */*
> 
* Mark bundle as not supporting multiuse
< HTTP/1.1 200 OK
< Date: Thu, 18 Aug 2022 20:26:31 GMT
< Content-Length: 28
< Content-Type: text/plain; charset=utf-8
< 
Prometheus Server is Ready.

@sekka1 sekka1 merged commit 59b9278 into main Aug 18, 2022
@sekka1 sekka1 deleted the testkube---prometheus-test-udpate branch August 18, 2022 21:11
nasheikh pushed a commit to nasheikh/kubernetes-ops that referenced this pull request Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant