Move telemetry out of lock scope (dotnet#105140)

ManickaP · Jul 19, 2024 · 9c220c4 · 9c220c4
1 parent 3648b56
commit 9c220c4
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/libraries/System.Net.NameResolution/src/System/Net/Dns.cs b/src/libraries/System.Net.NameResolution/src/System/Net/Dns.cs
@@ -703,9 +703,9 @@ private static Task<TResult> RunAsync<TResult>(Func<object, NameResolutionActivi
                         lock (s_tasks)
                         {
                             ((ICollection<KeyValuePair<object, Task>>)s_tasks).Remove(new KeyValuePair<object, Task>(key!, task));
-                            // Since it was canceled, func(..) had not executed and call AfterResolution it needs to be called here.
-                            NameResolutionTelemetry.Log.AfterResolution(key!, activity, new OperationCanceledException());
                         }
+                        // Since it was canceled, func(..) had not executed and call AfterResolution it needs to be called here.
+                        NameResolutionTelemetry.Log.AfterResolution(key!, activity, new OperationCanceledException());
                     }, key, CancellationToken.None, TaskContinuationOptions.OnlyOnCanceled | TaskContinuationOptions.ExecuteSynchronously, TaskScheduler.Default);
                 }