-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type annotations for manim/scene/*.py #3981
Open
henrikmidtiby
wants to merge
45
commits into
ManimCommunity:main
Choose a base branch
from
henrikmidtiby:type_annotations_scene
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
ba5c73a
Removed typing errors in mobject/geometry/shape_matchers.py
henrikmidtiby c6e071f
Added type annotations fo mobject/types/image_mobject.py and a few ot…
henrikmidtiby 758e199
Adding type annotations to types/point_cloud_mobject.py
henrikmidtiby b54a624
Fixing issues revealed by type annotations in types/point_cloud_mobje…
henrikmidtiby bdf0049
Fix issue in the CI step related to the Camera class.
henrikmidtiby 1962c73
Adding type annotations to geometry/line.py
henrikmidtiby 92d9908
Ignore type errors related to super and sub class in line.py and shap…
henrikmidtiby bd4f02a
Dealing with some issues and ignoring others identified by type checking
henrikmidtiby a4bda5d
Ignored a number of type issues related to float and floating[Any].
henrikmidtiby 45e18e8
Help mypy to determine types.
henrikmidtiby c29a38e
More work on addressing typing issues.
henrikmidtiby 11e6ffa
Reverting two changes that triggers an error in the automatic testing.
henrikmidtiby 935fd0c
Further work on type hinting.
henrikmidtiby 00f546d
Avoid forwarding positional arguments from Arrow to Line in the const…
henrikmidtiby 020a777
Revert "Avoid forwarding positional arguments from Arrow to Line in t…
henrikmidtiby ef6158a
Removed several type ignore statements and addressed comments from Ja…
henrikmidtiby e79fd75
Revert "Activate mypy check of mobject.geometry.*"
henrikmidtiby c85a19d
Revert "Removed several type ignore statements and addressed comments…
henrikmidtiby 6243990
Added type annotations to zoomed_scene.py
henrikmidtiby ae06d89
Adding type annotations to all methods in vector_space_scene.py
henrikmidtiby 8d6d9c4
Get rid of no-untyped-call errors from my in the vector_space_scene.p…
henrikmidtiby e2284b1
Handle type issues related to ManimColor in vector_space_scene.py
henrikmidtiby bfe61b0
Handle var-annotated issues in vector_space_scene.py
henrikmidtiby eae2296
Handling has-type type errors in vector_space_scene.py
henrikmidtiby 9dd785a
Handled name-defined type issues in vector_space_scene.py
henrikmidtiby 822dba2
Address type issue with calling an untyped method.
henrikmidtiby 501d774
Fix some typing issues in transform_mathcing_parts.py
henrikmidtiby fa9cad9
Change stroke_width to float in vector_space_scene.py
henrikmidtiby 99c12c0
Handled a few type errors.
henrikmidtiby dee6ef9
Handled several typing issues in three_d_scene.py
henrikmidtiby 5bf2d0e
Dealing with type errors in scene_file_writer.py
henrikmidtiby da35261
Ensured that all methods in scene.py have type declarations.
henrikmidtiby 79790db
Handle type issues related to interactivity by asserting that the cam…
henrikmidtiby 080113f
Handle type issues in scene.py
henrikmidtiby abd7022
Asserting that the renderer or camera is of the proper type to use ce…
henrikmidtiby 3fc6197
Avoid cyclic import of dependencies
henrikmidtiby c5d5743
Handling no-untyped-call type errors in manim/scene/scene.py
henrikmidtiby 90de428
Handling assignment type errors in manim/scene/*.py
henrikmidtiby 0a8c41e
Handling arg-type type errors in manim/scene/*.py
henrikmidtiby e8d9741
Handling arg-type type errors in manim/scene/*.py
henrikmidtiby 059566e
Fixing various type errors
henrikmidtiby 5bba091
Fixing various type errors
henrikmidtiby 1165469
Fixing various type errors
henrikmidtiby 4c14674
Some aggressive changes to silence a significant number of type errors.
henrikmidtiby bf7a82f
Commented out an import (IPython) that makes the CI tests fail.
henrikmidtiby File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check failure
Code scanning / CodeQL
Module-level cyclic import Error