feat: make slack support channel configurable #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fleboulch
force-pushed
the
contrib/make-moes-tavern-configurable
branch
from
f21b778
to
444d39d
Compare
greg0ire
previously approved these changes
Jun 14, 2024
fleboulch
force-pushed
the
contrib/make-moes-tavern-configurable
branch
from
444d39d
to
cfa3203
Compare
|
Yes you did it but when I did a force push, it has been removed |
|
No: I already dismissed it on my own :) |
greg0ire
reviewed
Jun 14, 2024
|
I tried my best with the 2nd commit but the assertion in the waitFor is always failing. Feel free to update |
|
@pfongkye, maybe? |
Hello, I will take a look. |
|
@pfongkye did you have some time to check this MR? |
pfongkye
reviewed
Jul 3, 2024
pfongkye
reviewed
Jul 3, 2024
fleboulch
force-pushed
the
contrib/make-moes-tavern-configurable
branch
6 times, most recently
from
d722162
to
6f5a297
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
==========================================
+ Coverage 75.63% 75.66% +0.02%
==========================================
Files 93 93
Lines 1884 1886 +2
Branches 366 366
==========================================
+ Hits 1425 1427 +2
Misses 429 429
Partials 30 30 ☔ View full report in Codecov by Sentry. |
fleboulch
force-pushed
the
contrib/make-moes-tavern-configurable
branch
from
6f5a297
to
56a9d58
Compare
fleboulch
force-pushed
the
contrib/make-moes-tavern-configurable
branch
from
56a9d58
to
419c0b1
Compare
|
@pfongkye the MR is ready for review 🚀 |
greg0ire
reviewed
Aug 9, 2024
Co-authored-by: Grégoire Paris <[email protected]>
Co-authored-by: Grégoire Paris <[email protected]>
greg0ire
reviewed
Aug 9, 2024
Co-authored-by: Grégoire Paris <[email protected]>
|
@greg0ire I applied the changes you suggested |
greg0ire
approved these changes
Aug 9, 2024
pfongkye
approved these changes
Aug 21, 2024
|
Thanks @fleboulch ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.