Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin): add simple plugin manager for release #42

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

pfongkye
Copy link
Contributor

@pfongkye pfongkye commented Oct 14, 2024

  • Adding a simple release plugin manager to allow for custom release managers to be added.
  • Add your custom release manager to plugins/release folder at build time (if you add the plugin after the app starts, it won't be loaded dynamically).

TODO:

  • extract types in its own npm package for implementing custom release manager.
  • Add documentation on how to add custom release manager.
  • Make release tag managers available as plugins also.

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 85.84906% with 15 lines in your changes missing coverage. Please review.

Project coverage is 78.36%. Comparing base (8d98eff) to head (d50ed0d).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/release/utils/ConfigHelper.ts 78.57% 6 Missing ⚠️
...mands/create/hookHandlers/deploymentHookHandler.ts 40.00% 3 Missing ⚠️
...ase/commands/cancel/cancelReleaseRequestHandler.ts 33.33% 2 Missing ⚠️
src/release/releaseOptions.ts 83.33% 2 Missing ⚠️
...mands/create/viewBuilders/buildReleaseModalView.ts 80.00% 1 Missing ⚠️
src/release/releaseBlockActionsHandler.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
+ Coverage   76.50%   78.36%   +1.85%     
==========================================
  Files          94       94              
  Lines        1911     1895      -16     
  Branches      371      342      -29     
==========================================
+ Hits         1462     1485      +23     
+ Misses        419      401      -18     
+ Partials       30        9      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pfongkye pfongkye force-pushed the feat/plugin-manager branch 3 times, most recently from 7f6e76d to 703b572 Compare October 17, 2024 10:41
@pfongkye pfongkye self-assigned this Oct 17, 2024
@pfongkye pfongkye marked this pull request as ready for review October 17, 2024 14:20
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition!

PLUGIN_RELEASE.md Outdated Show resolved Hide resolved
Co-authored-by: Grégoire Paris <[email protected]>
@greg0ire greg0ire merged commit 56b0f4b into ManoManoTech:main Oct 17, 2024
3 checks passed
@pfongkye pfongkye deleted the feat/plugin-manager branch October 17, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants