-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose more ports in dockerfile #373
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please say why we're doing this change in the description.
We need to be able to easily realize what's happening in this PR if we open it after 6 months.
Updated. |
As relay- and parachain both run on the same device ( or in case of docker more specifically: in the same container ) since they are the same binary, they will be able to find each other even without exposed ports. Also I'm not sure why the parachain should talk on the relaychain p2p port, i would imagine they exchange messages on websocket or rpc. The problem begins when external nodes want to reach the relaychain node on 30334 which won't be available unless exposed. See also the discussion in https://github.com/Manta-Network/docs/pull/15/files#r800349071 |
I think ws and rpc are for applications, but exchanging messages between parachain and relaychain is by p2p(libp2p). Parachain should have two peer sets, one saves parachain peer addresses, another one has relaychain peer addresses. |
I'm still digging around the code, but I'm positive they don't talk p2p or RPC or WS for that matter. There seems to be work to split the relaychain node out from the parachain in paritytech/cumulus#545 |
@Garandor do we have any conclusion on the port issue? |
Description
30334 is a port for connecting relaychain by default, I think we should expose this port in case there's any connection issue between relaychain and parachain.
closes: #372
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
manta
ordolphin
) with right title (start with [Manta] or [Dolphin]),Files changed
in the Github PR explorer.authoring_version
: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.spec_version
: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.impl_version
: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.transaction_version
: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. If this number is updated, then the spec_version must also be updatedversion
for every crate.BaseFilter
. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.