Added RotatingFileHandler and changed print statements to use logger #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- switched most occurrences of "print" to "logger"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last time I used CraftBeerPi for fermentation I wanted to take a look into the logfile after several days. At this point of time had the logfile a size of roughly 100MB. Which led me to this pull request to use a RotatingFileHandler and change the print statements to use the logger directly. From my experience the next steps have to be to log more often with the goal to make it more comprehensible what the app realy does. Otherwise it will be very hard to help people in case of an error.