Add support for SSL. #249
Open
Add support for SSL. #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove hardcoded http protocol for polling. bundle.js are using location.protocol instead of "http://" now.
|
Nice catch! I was struggling to get this to work behind a reverse proxy until I found this. Since we want to just use the same protocol, domain and port as the origin, instead of: connect(location.protocol + "//" +document.domain+":"+location.port+"/brew")How about just simplifying to: connect("/brew")Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove hardcoded http protocol for polling.
bundle.js are using location.protocol instead of "http://" now.